Why does the following work?

<something>.stop().animate(
    { 'top' : 10 }, 10
);

Whereas this doesn't work:

var thetop = 'top';
<something>.stop().animate(
    { thetop : 10 }, 10
);

To make it even clearer: At the moment I'm not able to pass a CSS property to the animate function as a variable.

6 Answers 11

up vote 389 down vote accepted

{ thetop : 10 } is a valid object literal. The code will create an object with a property named thetop that has a value of 10. Both the following are the same:

obj = { thetop : 10 };
obj = { "thetop" : 10 };

In ES5 and earlier, you cannot use a variable as a property name inside an object literal. Your only option is to do the following:

var thetop = "top";

// create the object literal
var aniArgs = {};

// Assign the variable property name with a value of 10
aniArgs[thetop] = 10; 

// Pass the resulting object to the animate method
<something>.stop().animate(
    aniArgs, 10  
);  

ES6 defines ComputedPropertyName as part of the grammar for object literals, which allows you to write the code like this:

var thetop = "top",
    obj = { [thetop]: 10 };

console.log(obj.top); // -> 10

You can use this new syntax in the latest versions of each mainstream browser.

upvote
  flag
I understand! Thank you! Shoudln't this also work with eval? I mean it doesn't work in my example at the moment, but I thin it should... :-) – speendo
2 upvote
  flag
@Marcel: eval() wouldn't work inside an object literal for dynamic property names, you'd just get an error. Not only that, but eval() really shouldn't be used for such things. There's an excellent article on correct and incorrect usage of eval: blogs.msdn.com/ericlippert/archive/2003/11/01/53329.aspx – Andy E
upvote
  flag
@AndyE consider updating "recent versions" and "current IE TP" with some more specific time like "Versions later than XXX" or "after 2014-mm" (I'd make change myself, but I don't know what good values would be. – Alexei Levenkov

I have used the following to add a property with a "dynamic" name to an object:

var key = 'top';
$('#myElement').animate(
   (function(o) { o[key]=10; return o;})({left: 20, width: 100}),
   10
);

key is the name of the new property.

The object of properties passed to animate will be {left: 20, width: 100, top: 10}

This is just using the required [] notation as recommended by the other answers, but with fewer lines of code!

ES5 quote that says it should not work

Spec: http://www.ecma-international.org/ecma-262/5.1/#sec-11.1.5

PropertyName :

  • IdentifierName
  • StringLiteral
  • NumericLiteral

[...]

The production PropertyName : IdentifierName is evaluated as follows:

  1. Return the String value containing the same sequence of characters as the IdentifierName.

The production PropertyName : StringLiteral is evaluated as follows:

  1. Return the SV [String value] of the StringLiteral.

The production PropertyName : NumericLiteral is evaluated as follows:

  1. Let nbr be the result of forming the value of the NumericLiteral.
  2. Return ToString(nbr).

This means that:

  • { theTop : 10 } is the exact same as { 'theTop' : 10 }

    The PropertyName theTop is an IdentifierName, so it gets converted to the 'theTop' string value, which is the string value of 'theTop'.

  • It is not possible to write object initializers (literals) with variable keys.

    The only three options are IdentifierName (expands to string literal), StringLiteral, and NumericLiteral (also expands to a string).

Rules have changed for ES6: //allinonescript.com/a/2274327/895245

2 upvote
  flag
Downvoters: I was the first to quote any standard on this question. The ES6 quote on the top answer was edited after I answered, and that standard was not yet accepted at the time. If you happen to know why else I'm getting downvotes, please explain, I just want to learn. I might as well get the peer pressure badge... – Ciro Santilli 华涌低端人口 六四事件 法轮功
upvote
  flag
I guess the downvote was mostly because your answer doesn't offer a solution, and is "not useful" in that regard. Voting towards peer pressure :-) – Bergi
2 upvote
  flag
@Bergi thanks for having the courage! :-) But I think I have answered the question directly: Q: "Why does the following work?". A: because ES5 says so. "What to do about it?" is implicit. Did you downvote the top question for saying "It is impossible" without a standard quote before someone edited in the ES6 solution? – Ciro Santilli 华涌低端人口 六四事件 法轮功
upvote
  flag
Ah, right. I typically cite the specific questions in a blockquote to make it clear when I answer them directly. Quoting the standard can make a good answer even better, but currently your post doesn't even answer the question imo. Stating what can make a key in ES5 doesn't imply how they work. Surely thetop is an IdentifierName, so why does it not work? That question is still open. – Bergi
1 upvote
  flag
@Bergi thanks again for explaining to me! I have updated it to make it more explicit. I hadn't done it before because I though it was obvious, because we can write {a:1}.a, so a clearly not expand the variable value in the identifier case. But yes, explaining further is an improvement in this case. – Ciro Santilli 华涌低端人口 六四事件 法轮功

With ECMAScript 2015 you are now able to do it directly in object declaration with the brackets notation: 

var obj = {
  [key]: value
}

Where key can be any sort of expression (e.g. a variable) returning a value.

So here your code would look like:

<something>.stop().animate({
  [thetop]: 10
}, 10)

Where thetop will be replaced by the variable value.

Adding square bracket around the variable works good for me. Try this

var thetop = 'top';
<something>.stop().animate(
    { [thetop] : 10 }, 10
);
upvote
  flag
This won't work in older versions of EcmaScript, but nowadays this is a very clean approach. – Oliver

Given code:

var thetop = 'top';
<something>.stop().animate(
    { thetop : 10 }, 10
);

Translation:

var thetop = 'top';
var config = { thetop : 10 }; // config.thetop = 10
<something>.stop().animate(config, 10);

As you can see, the { thetop : 10 } declaration doesn't make use of the variable thetop. Instead it creates an object with a key named thetop. If you want the key to be the value of the variable thetop, then you will have to use square brackets around thetop:

var thetop = 'top';
var config = { [thetop] : 10 }; // config.top = 10
<something>.stop().animate(config, 10);

The square bracket syntax has been introduced with ES6. In earlier versions of JavaScript, you would have to do the following:

var thetop = 'top';
var config = (
  obj = {},
  obj['' + thetop] = 10,
  obj
); // config.top = 10
<something>.stop().animate(config, 10);

Not the answer you're looking for? Browse other questions tagged or ask your own question.